----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48640/#review137503 -----------------------------------------------------------
Ship it! Ship It! - Eugene Chekanskiy On June 13, 2016, 6:50 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48640/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 6:50 p.m.) > > > Review request for Ambari, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-17177 > https://issues.apache.org/jira/browse/AMBARI-17177 > > > Repository: ambari > > > Description > ------- > > Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to the following roles: > > * AMBARI.ADMINISTRATOR > * CLUSTER.ADMINISTRATOR > * CLUSTER.OPERATOR > * SERVICE.ADMINISTRATOR > > This is a DB change adding an authorization record to the `roleauthorization` > table and relevant records for the different roles to the > `permission_roleauthorization` table. > > The description/name of the `SERVICE.VIEW_OPERATIONAL_LOGS` authorization > should be > ``` > View service operational logs > ``` > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > 33ed7ed > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RoleAuthorizationDAO.java > aa74224 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java > ee948fe > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 3ee8bba > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java > 6b038f4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 5016325 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fff1716 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e7eff93 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql b90c7da > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b9181d2 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > c840b9c > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 742eaa3 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 87ef7fb > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java > d7e13ea > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > c221138 > > Diff: https://reviews.apache.org/r/48640/diff/ > > > Testing > ------- > > Manually tested upgrade and new cluster creation > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:16:17.022s > [INFO] Finished at: Mon Jun 13 09:41:19 EDT 2016 > [INFO] Final Memory: 59M/1881M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test results: > > Tests run: 4478, Failures: 0, Errors: 0, Skipped: 34 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:38 h > [INFO] Finished at: 2016-06-13T17:03:59+00:00 > [INFO] Final Memory: 152M/527M > [INFO] > ------------------------------------------------------------------------ > > > {color:green}+1 overall{color}. Here are the results of testing the latest > attachment > > http://issues.apache.org/jira/secure/attachment/12809853/AMBARI-17177_trunk_01.patch > against trunk revision . > > {color:green}+1 @author{color}. The patch does not contain any @author > tags. > > {color:green}+1 tests included{color}. The patch appears to include 2 > new or modified test files. > > {color:green}+1 javac{color}. The applied patch does not increase the > total number of javac compiler warnings. > > {color:green}+1 release audit{color}. The applied patch does not > increase the total number of release audit warnings. > > {color:green}+1 core tests{color}. The patch passed unit tests in > ambari-admin ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7322//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7322//console > > > Thanks, > > Robert Levas > >