> On June 14, 2016, 11:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
> >  line 930
> > <https://reviews.apache.org/r/48670/diff/1/?file=1417435#file1417435line930>
> >
> >     How is this a fix?
> >     If a host has any masters, we shouldn't allow deleting it. Slaves must 
> > be stopped. Clients can be in any state.

I had a discussion with Sumit and we aggreed on failing even for clients.


- Ajit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137629
-----------------------------------------------------------


On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 12:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17210
>     https://issues.apache.org/jira/browse/AMBARI-17210
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Return well formatted error response while deleting host with clients 
> installed.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  46fc65295f72bae39c534cd9684f2d76d1e30224 
> 
> Diff: https://reviews.apache.org/r/48670/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> delete 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
> internal system exception occurred: Cannot remove host 
> c6403.ambari.apache.org from c1.  The following roles exist, and these 
> components must be stopped if running, and then deleted: HDFS_CLIENT, 
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Reply via email to