> On June 15, 2016, 5:51 p.m., Jayush Luniya wrote:
> > Ship It!

For 2.4 and trunk, we should not have any hdp-select and hdp hardcodings. 
Everything should be stack config driven.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review137780
-----------------------------------------------------------


On June 13, 2016, 9:22 a.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 9:22 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
>     https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> Based on the git logs the affected codebase has been refactored as part of 
> AMBARI-15329.
> (This addition should be ported to the newer versions isf applicable)
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Reply via email to