-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48727/#review137811
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 (line 133)
<https://reviews.apache.org/r/48727/#comment202998>

    Not sure I understood this use case. The defaults from the properties is 
only used for bootstraping values in the Solr. Once it is in the Solr, users 
might change the default values via LogSearch UI. If we overwrite the values in 
Solr on each startup, then any user changes will be lost.
    
    I assume, this requirement is coming due to support for new services that 
could be added later. If so, we might have to change the logic for bootstraping 
the initial values.
    
    If this is the case, we might have to discuss more.


- Don Bosco Durai


On June 15, 2016, 12:46 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48727/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 12:46 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17254
>     https://issues.apache.org/jira/browse/AMBARI-17254
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The default log levels (log levels to include) can not be altered, forever 
> the ones set during the installation (more precisely: the one which is the 
> value of the property during the first run of the portal) would be in effect.
> 
> Currently the portal checks if there is a configuration, and does nothing if 
> there is. After this change it will remove any existing configuration upon 
> starting, and replace it with a newly generated configuration.
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  edf1dcc 
> 
> Diff: https://reviews.apache.org/r/48727/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to