> On June 15, 2016, 7:11 p.m., Don Bosco Durai wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py,
> >  line 82
> > <https://reviews.apache.org/r/48741/diff/1/?file=1420250#file1420250line82>
> >
> >     We should set explicit permission to this path. Only 
> > logsearch-solr-user, logsearch-user, ranger-user and atlas-user should have 
> > write permission. Essentially, in addition to logsearch-solr-user, only 
> > other who need to upload config into zookeeper should have write permission.
> >     
> >     I have also seen cases, where if we don't protect zookeeper path, then 
> > if knit'ed user accesses zookeeper, then it will fail.
> 
> Oliver Szabo wrote:
>     can it be done in different patch? just because im not sure zkcli of solr 
> is able to set ACLs. if not maybe the users should setup this manually with 
> zookeeper cli anyway.
> 
> Don Bosco Durai wrote:
>     Yes, we could do it later. We also need to see how hbase is doing it.
> 
> Oliver Szabo wrote:
>     If zkcli cannot do that we can still use the logsearch-solr-client to set 
> ACLs programmatically

You are correct. logsearch-solr-client has the zookeeper client. We just have 
to run it with the appropriate user permisison to change the permission of the 
zookeeper path


- Don Bosco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48741/#review137798
-----------------------------------------------------------


On June 15, 2016, 5:37 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48741/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 5:37 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Levas, 
> Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16736
>     https://issues.apache.org/jira/browse/AMBARI-16736
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Basuc logsearch solr kerberos support.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  e0a30ed 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml bbe0bc9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  b14c273 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  076c09c 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml e83c75b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  cd4ef93 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  37c8317 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml b634928 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  a2da737 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
>  2805b0b 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
>  0813221 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> 85762e0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  d27067c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  3682e5d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  2420be0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  6dd4aa7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  ce7f71c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  2b5fdf7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  d0ac389 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
>  b55f3d6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  8a1449d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  5d1ca85 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  368db03 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
>  eac60db 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
>  1efe605 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  6a52708 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  9ada5bf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch_solr_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/zoo.cfg.j2
>  1f3808b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  9f76d18 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 7cbbfc4 
> 
> Diff: https://reviews.apache.org/r/48741/diff/
> 
> 
> Testing
> -------
> 
> ambari server python unit test output:
> 
> Total run:1061
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to