> On 6月 15, 2016, 5:56 p.m., Aravindan Vijayan wrote:
> > Masahiro, was this patch manually tested on a cluster?

Thank you for reviewing ! I retested on a cluster and added screenshots before 
and after patched.
See https://issues.apache.org/jira/browse/AMBARI-17181
I just checked that the WebUI has changed.

I'm sorry but I noticed that I can't apply the previous patch to the latest 
trunk, I update the patch with some modification.


- Masahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48607/#review137783
-----------------------------------------------------------


On 6月 16, 2016, 3:55 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48607/
> -----------------------------------------------------------
> 
> (Updated 6月 16, 2016, 3:55 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17181
>     https://issues.apache.org/jira/browse/AMBARI-17181
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Some of the property files in AMBARI_METRICS lack value-attributes.
> It would be nice to have value-attributes on most of the properties. If so, 
> we can notice a careless mistakes in Ambari Server WebUI.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml
>  eaafc6b 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml
>  da4599e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  3ce1af2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  f4e5fb2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  6484285 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
>  6f9c6dc 
> 
> Diff: https://reviews.apache.org/r/48607/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to