-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48041/#review137961
-----------------------------------------------------------



Hi Dmitry, what's the status of this review/patch?

- Nate Cole


On May 30, 2016, 9:30 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48041/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 9:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-16954
>     https://issues.apache.org/jira/browse/AMBARI-16954
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *Steps*
> # Deploy HDP-2.4.0.0 cluster with Ambari 2.2.2
> # Upgrade Ambari to 2.4.0.0
> # Register HDP-2.5.0.0 version and install the bits
> # Modify configs for some of the service like HDFS, ZK, YARN
> # Start EU
> 
> *Result*:
> EU pre-check does *not* report below error for the three services whose 
> config was modified in step 4
> "The following service configurations have been updated and their Service 
> Checks should be run again:"
> 
> Upon further investigation found that the pre-check does not work if a 
> service check has never been run for a service at all AND reports success in 
> such cases
> In other words, the comparison between last config modification time and last 
> service check time succeeds if service check never ran at all and the output 
> of below query returns empty:
> {code}
> SELECT start_time FROM host_role_command where role = 'HDFS_SERVICE_CHECK' 
> AND status = 'COMPLETED' ORDER BY start_time DESC;
> {code}
> 
> In this case when I manually ran a service check for HDFS and retried EU, the 
> pre-check caught the mismatch and reported error
> 
> *Note*: I believe we do run service check as part of cluster install, but 
> looks like it does not get updated in the DB tables for all services.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  9abfa50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  55429bd 
> 
> Diff: https://reviews.apache.org/r/48041/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to