> On Июнь 16, 2016, 2:56 п.п., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 2693
> > <https://reviews.apache.org/r/48729/diff/1/?file=1419737#file1419737line2693>
> >
> >     My concern here is that there is no way for a Blueprint developer to 
> > customize this property to the "0.0.0.0" address. 
> >     
> >     My sense is that it is possible that customers might want to do this, 
> > and so we should have some way to check if this property was set in the 
> > Blueprint, or is relying on the stack defaults. 
> >     
> >     I realize that this change is not really a part of this current patch, 
> > but this looks like something that needs some investigation, and some 
> > clarification from the Metrics team.

if user set ams-site/timeline.metrics.service.webapp.address to 0.0.0.0:6188, 
ams alerts won't work.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48729/#review137985
-----------------------------------------------------------


On Июнь 15, 2016, 1:35 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48729/
> -----------------------------------------------------------
> 
> (Updated Июнь 15, 2016, 1:35 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17255
>     https://issues.apache.org/jira/browse/AMBARI-17255
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After updating the property timeline.metrics.service.webapp.address to 
> 0.0.0.0:6188 (earlier it was localhost:6188), I am able to access metadata 
> using the command curl http://host1:6188/ws/v1/timeline/metrics/metadata
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  9094698 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  9ff1273 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  cda8fb8 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  b7d96b7 
> 
> Diff: https://reviews.apache.org/r/48729/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to