-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48812/
-----------------------------------------------------------

(Updated June 16, 2016, 4:27 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17282
    https://issues.apache.org/jira/browse/AMBARI-17282


Repository: ambari


Description
-------

The user can specify the display name when creating a version using VDF. In 
that case, use that for the repository version string as well. This does not 
cause problems as the version will get replaced at install time. We just need a 
way to provide uniqueness in the DB.

Also sneaked in an ask by the FE to supply stack min/max jdk with the output.  
They did not want to make an extra call to get that information.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 4a061c5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
 6b66f12 

Diff: https://reviews.apache.org/r/48812/diff/


Testing (updated)
-------

Manual.  Automated (failures from other patches):

Tests in error:
  ServiceComponentTest.testHistoryCreation:406 » NoSuchElement
  ServiceComponentTest.testHistoryRemoval:516 » NoSuchElement

Tests run: 4481, Failures: 0, Errors: 2, Skipped: 34

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:58.287s
[INFO] Finished at: Thu Jun 16 16:25:33 EDT 2016
[INFO] Final Memory: 33M/665M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole

Reply via email to