-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48814/#review138127
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On June 16, 2016, 9:13 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48814/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 9:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17283
>     https://issues.apache.org/jira/browse/AMBARI-17283
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following changes have bee done: 
> 
> 4 configs that are of interest to us, which need to show up as LABEL in Hive 
> Server interactive panel : 
>     - hive-interactive-site/hive.llap.daemon.yarn.container.mb 
> **(Screenshot_1)**
>     - hive-interactive-site/hive.llap.daemon.num.executors **(Screenshot_2)**
>     - hive-interactive-site/hive.llap.io.memory.size **(Screenshot_3)**
>     - hive-interactive-env/num_llap_nodes **(Screenshot_4)**
> 
> Made copies of these configs as follows, to be used as LABELs:
>     - hive-interactive-site/hive.llap.daemon.yarn.container.mb**_copy**
>     - hive-interactive-site/hive.llap.daemon.num.executors**_copy**
>     - hive-interactive-site/hive.llap.io.memory.size**_copy**
>     - hive-interactive-env/num_llap_nodes**_copy**
> 
>     - Screenshot : Screenshot_5
> 
> 2.5/HIVE/theme.json has been modified to use '*_copy' configs for display on 
> HIVE SERVER INTERACTIVE panel.
>     - Thus, existing 4 configs will now be seen editable in HIVE Advanced 
> section.
> 
> At any point, wherever, existing configs value will change for eg: 
> 'hive.llap.io.memory.size' (and same applies for others), 
> the corresponding value for config '*_copy' will be updated, with SA code 
> supporting that update to be take place.
> 
> **Example:** 
> 
> {code}
>  <property>
>     <name>hive.llap.io.memory.size_copy</name>
>     <!--
>        Added for displaying 'hive.llap.io.memory.size' value as a 'label' on 
> Hive Server Interactive panel and will always
>       have same value as 'hive.llap.io.memory.size'. 
> 'hive.llap.io.memory.size' will stay editable in Advanced section.
>     -->
>     <display-name>In-Memory Cache per Daemon</display-name>
>     <description>The amount of memory reserved for Hive's optimized in-memory 
> cache.</description>
>     <value>0</value>
>     <value-attributes>
>       <type>int</type>
>       <unit>MB</unit>
>       <overridable>false</overridable>
>     </value-attributes>
>     <depends-on>
>       <property>
>         <type>hive-interactive-env</type>
>         <name>enable_hive_interactive</name>
>       </property>
>       <property>
>         <type>hive-interactive-site</type>
>         <name>hive.llap.io.memory.size</name>
>       </property>
>     </depends-on>
>     <on-ambari-upgrade add="true"/>
>   </property>
> {code}
> 
> 
> Thus, both set of configs will stay in parity at all times.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  4d34455 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  1b2eaf5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  395ae43 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b896a6a 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 7d5a03f 
> 
> Diff: https://reviews.apache.org/r/48814/diff/
> 
> 
> Testing
> -------
> 
> - Python UT tests added.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_1
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/16/2726343c-9141-46f5-8bb7-a77e4c7a3964__Screen_Shot_2016-06-16_at_1.56.00_PM.png
> Screenshot_2
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/16/5fd0e584-3c8a-4a36-8cee-7077fad6ae79__Screen_Shot_2016-06-16_at_1.56.17_PM.png
> Screenshot_3
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/16/7209541b-b59d-4feb-a8d9-006483a6f127__Screen_Shot_2016-06-16_at_1.56.31_PM.png
> Screenshot_4
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/16/868a0a78-0272-4f11-90f8-7620f834c1db__Screen_Shot_2016-06-16_at_1.56.43_PM.png
> Screenshot_5
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/16/f49ce765-b23f-45b1-9c7a-a879e31b6530__Screen_Shot_2016-06-16_at_1.55.20_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to