-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48797/#review138199
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 16, 2016, 7:49 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48797/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 7:49 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17279
>     https://issues.apache.org/jira/browse/AMBARI-17279
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> General problem:
> 
> 1) Clients were installed successfully. All clients are in the state 
> INSTALLED.
> 
> 2) "Start all" was executed. Clients were transitioned to INSTALLING.
> 
> 3) "Start all" was aborted. Clients were transitioned to INSTALL_FAILED. <-- 
> we should fix this.
> 
> 
> 2 another conditions when SCH event can't be handled:
> 
> 1) Aborted or failed custom command
> 
> service is started -> restart all on UI -> abort restart request
> 
> Reason: component is in the STARTED state. Custom command RESTART doesn't 
> change it's state (it sends HOST_SVCCOMP_OP_IN_PROGRESS on start). On abort 
> HOST_SVCCOMP_OP_FAILED fired, can't handle this in the STARTED state.
> 
> Probably it can occur not only on abort, but on failure of a custom command.
> 
> 2) Aborted start request
> 
> "Start all" -> abort
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8ecf63f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
>  464df17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  4f8fda6 
> 
> Diff: https://reviews.apache.org/r/48797/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to