----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48827/#review138316 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 778) <https://reviews.apache.org/r/48827/#comment203486> Would be more efficient to use 'server_host' variable instead of resolving fqdn from socket everytime. Similar comment to other calls. - Srimanth Gunturi On June 16, 2016, 11:43 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48827/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 11:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Srimanth > Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17286 > https://issues.apache.org/jira/browse/AMBARI-17286 > > > Repository: ambari > > > Description > ------- > > Service config links (e.g. tez.tez-ui.history-url.base) need to use the > Ambari server's public name / IP instead of the private one. (Since > tez.tez-ui.history-url.base is used to navigate from RM UI to Tez View.) > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 038a6c3 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c32306d > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 318f184 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 1bd385f > > Diff: https://reviews.apache.org/r/48827/diff/ > > > Testing > ------- > > Unit tests for stack advisor passed > Total run:162 > Total errors:0 > Total failures:0 > OK > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
