----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48793/#review138532 -----------------------------------------------------------
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 65) <https://reviews.apache.org/r/48793/#comment203731> This constant is already present in LogFeederConstants.java, you can take it from there. ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java (line 66) <https://reviews.apache.org/r/48793/#comment203732> same as above, only the constant name is "NAME". I think it will be better to change the constant name also in LogFeederConstants.java for "NAME". - Dharmesh Makwana On June 19, 2016, 10:39 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48793/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 10:39 p.m.) > > > Review request for Ambari, Don Bosco Durai, Dharmesh Makwana, Oliver Szabo, > Robert Nettleton, and Sumit Mohanty. > > > Bugs: Ambari-17277 > https://issues.apache.org/jira/browse/Ambari-17277 > > > Repository: ambari > > > Description > ------- > > After Log Search is started it sends the filters to the Solr which describes > what log levels should be persisted. In the meantime Logfeeders start to push > their data, which is not filtered. The result is misleading, the user may > find it add that some specific level logs are loaded, others are not. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > b14c273 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java > 29feef7 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 076c09c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > afbccca > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2 > 6a52708 > > Diff: https://reviews.apache.org/r/48793/diff/ > > > Testing > ------- > > logfeeder: > Tests run: 35, Failures: 0, Errors: 0, Skipped: 0 > > ambari-server > Total run:1062 > Total errors:0 > Total failures:0 > > > Thanks, > > Miklos Gergely > >
