> On June 20, 2016, 8:03 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py,
> >  lines 124-125
> > <https://reviews.apache.org/r/48854/diff/3/?file=1422625#file1422625line124>
> >
> >     Why the retry params are passed instead of using any of the rety 
> > annotations directly on the upload_configuration_to_zk function?

in logsearch-solr-client, there is an inner retry logic, so i used them (the 
default is about max 50 seconds, it can be too low if we install with 
blueprints and solr is on a different host from atlas/ranger/logsearch)


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48854/#review138542
-----------------------------------------------------------


On June 17, 2016, 6:38 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48854/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 6:38 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17294
>     https://issues.apache.org/jira/browse/AMBARI-17294
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - use zookeeper quorum instead of zookeeper hosts (although zkcli looks like 
> working with that too)
> - rery logic for znode creation and remove ignoreFailure from zkcli commands
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  1abf2c1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  368db03 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
>  eac60db 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b86a09b 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> de355ea 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> ebf563d 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 7cbbfc4 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 8729195 
> 
> Diff: https://reviews.apache.org/r/48854/diff/
> 
> 
> Testing
> -------
> 
> ambari server python tests passed.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to