> On Червень 17, 2016, 10:27 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 576
> > <https://reviews.apache.org/r/48863/diff/1/?file=1422610#file1422610line576>
> >
> >     Shouldn't Ambari Upgrade be responsible for adding any config types 
> > that are missing?
> >     In other words, can this be implemented more generally instead of just 
> > for Slider?

We discussed this issue in internal jira with Sumit. According to our new 
upgrade logic we will not add empty configs. In the same time we have db 
consistency check which validates if all required configs are mapped to 
service. So, we decided to add it by default because this config is out of 
logic.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48863/#review138330
-----------------------------------------------------------


On Червень 17, 2016, 6:30 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48863/
> -----------------------------------------------------------
> 
> (Updated Червень 17, 2016, 6:30 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17302
>     https://issues.apache.org/jira/browse/AMBARI-17302
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Cluster deployed via BP based on ambari 2.2.1 have no slider-client config. 
> After upgrade to ambari 2.4.0 this issue appears
> 2016-06-16 01:19:10,963 INFO - ******************************* Check database 
> started *******************************
> 2016-06-16 01:19:14,660 INFO - Checking for configs not mapped to any cluster
> 2016-06-16 01:19:14,681 INFO - Checking for configs selected more than once
> 2016-06-16 01:19:14,683 INFO - Checking for hosts without state
> 2016-06-16 01:19:14,684 INFO - Checking host component states count equals 
> host component desired states count
> 2016-06-16 01:19:14,685 INFO - Checking services and their configs
> 2016-06-16 01:19:16,045 ERROR - Required config(s): slider-client is(are) not 
> available for service SLIDER with service config version 2 in cluster 
> hortonhdp
> 2016-06-16 01:19:16,161 INFO - ******************************* Check database 
> completed *******************************
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  13206c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  1288053 
> 
> Diff: https://reviews.apache.org/r/48863/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to