> On June 21, 2016, 7:28 p.m., Robert Nettleton wrote:
> > This looks fine to me.
> > 
> > One question: Have you tested out the Ambari UI integration once HTTPS is 
> > enabled?  I would expect this to fail, since this configuration option did 
> > not exist when the integration code was written.
> > 
> > This patch does not need to be held up due to this, just wanted to make 
> > sure people are aware that the integration layer will have to uptake this 
> > new configuration option before the UI integration will work properly with 
> > HTTPS. I can implement that during my next set of LogSearch Integration 
> > changes. 
> > 
> > Thanks.
> 
> Oliver Szabo wrote:
>     you mean the REST API part? because maybe you are right about that. (from 
> the other side, its tested with SSL enabled Ambari UI). 
>     we have now some variations here based on these:
>     - ssl enabled for Solr
>     - ssl enabled for LogSearch
>     - ssl enabled for Ambari

Exactly, the REST API part is the area that will not likely work properly if 
HTTPS is enabled in the LogSearch server.  I'll just have to update the 
integration code to read the new config properties to establish the HTTP 
connection, rather than HTTP.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49036/#review138916
-----------------------------------------------------------


On June 21, 2016, 6:03 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49036/
> -----------------------------------------------------------
> 
> (Updated June 21, 2016, 6:03 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17348
>     https://issues.apache.org/jira/browse/AMBARI-17348
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add a property to choose whether or not the Log Search UI should run using 
> https.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 376dfee 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  993c532 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 6c687b9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  26a303c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  e0d42d3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  155ff04 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  d21a97f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
>  2993190 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  3f5db30 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
>  aba06c6 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  7b0aed3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  2b17e63 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  fc71dfc 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 848be40 
>   ambari-web/app/data/HDP2/site_properties.js 0262211 
> 
> Diff: https://reviews.apache.org/r/49036/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster, works fine with every combination of with/without 
> SSL Solr connect, and http/https protocol for Log Search UI.
> 
> ambari-server:
> OK
> ----------------------------------------------------------------------
> Total run:1072
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to