> On June 21, 2016, 7:12 a.m., Nitiraj Rathore wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java,
> >  line 123
> > <https://reviews.apache.org/r/48950/diff/1/?file=1425257#file1425257line123>
> >
> >     is this path being passed just for logging purpose?
> 
> Gaurav Nagar wrote:
>     yes. Path is passed for logging.

I don't think its right thing to pass a parameter for logging. I think it 
should be removed.


- Nitiraj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48950/#review138794
-----------------------------------------------------------


On June 20, 2016, 12:30 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48950/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 12:30 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17310
>     https://issues.apache.org/jira/browse/AMBARI-17310
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added Error handling for the rest call.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  5e0f3fa 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java
>  c3bd504 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java
>  39a595b 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/ServiceFormattedException.java
>  7b57bb2 
>   
> contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 
> f619848 
> 
> Diff: https://reviews.apache.org/r/48950/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to