> On June 21, 2016, 2:31 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json,
> >  lines 114-122
> > <https://reviews.apache.org/r/49012/diff/1/?file=1426239#file1426239line114>
> >
> >     This should go into a Jinja2 template file, which is comon practice for 
> > JAAS files.  See 
> > https://github.com/apache/ambari/blob/10ad39cfd87a2f11bdfbc3470fdf112bf1d83c1c/ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/templates/zookeeper_jaas.conf.j2

I have kept this logic to match with manual install of Ranger TagSync, there 
also we are not using jaas file format. The above properties need to get 
updated in 'atlas-application.properties'.

Below is the code logic handled from Ambari:
PropertiesFile(format('{ranger_tagsync_conf}/atlas-application.properties'),
    properties = params.tagsync_application_properties,
    mode=0755,
    owner=params.unix_user,
    group=params.unix_group
)

where params.tagsync_application_properties = 
dict(config["configurations"]["tagsync-application-properties"])


> On June 21, 2016, 2:31 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 287
> > <https://reviews.apache.org/r/49012/diff/1/?file=1426237#file1426237line287>
> >
> >     The lower-case form of `current_host` should be forced - 
> > `current_host.lower()`

Updated in latest patch


- Mugdha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49012/#review138836
-----------------------------------------------------------


On June 22, 2016, 6:30 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49012/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 6:30 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Robert Levas, Srimanth Gunturi, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17330
>     https://issues.apache.org/jira/browse/AMBARI-17330
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove below properties from ranger-tagsync-site.xml:
> - ranger.tagsync.atlas.to.ranger.service.mapping
> - ranger.tagsync.atlas.custom.resource.mappers
> 
> Add below property in ranger-tagsync-site.xml:
> - ranger.tagsync.source.atlasrest.username (default - empty)
> 
> Add below properties in tagsync-application-properties.xml only if cluster is 
> kerberized:
> - 
> atlas.jaas.KafkaClient.loginModuleName=com.sun.security.auth.module.Krb5LoginModule
> - atlas.jaas.KafkaClient.loginModuleControlFlag=required
> - atlas.jaas.KafkaClient.option.useKeyTab=true
> - atlas.jaas.KafkaClient.option.storeKey=true
> - atlas.jaas.KafkaClient.option.serviceName=kafka
> - atlas.jaas.KafkaClient.option.keyTab=tagsync_keytab_path
> - atlas.jaas.KafkaClient.option.principal=tagsync_jaas_principal
> - atlas.kafka.sasl.kerberos.service.name=kafka
> - atlas.kafka.security.protocol=SASL_PLAINTEXT
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  c5a575d 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> cd34cd9 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  61bdce0 
> 
> Diff: https://reviews.apache.org/r/49012/diff/
> 
> 
> Testing
> -------
> 
> Tested Ranger installation on centos 6 in secure env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to