-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49145/#review139242
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 1324)
<https://reviews.apache.org/r/49145/#comment204395>

    Missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 1333)
<https://reviews.apache.org/r/49145/#comment204396>

    Could `configAttributes.get("hidden")` be `null` if the stack has the 
following rather than the expected delimited collection of strings?
    
    ```
    <hidden/>
    ```



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 1348)
<https://reviews.apache.org/r/49145/#comment204398>

    Missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
(lines 507 - 508)
<https://reviews.apache.org/r/49145/#comment204400>

    This formatting is a little off...


- Robert Levas


On June 23, 2016, 6:38 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49145/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 6:38 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17223
>     https://issues.apache.org/jira/browse/AMBARI-17223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem is that they need to access the "javax.jdo.option.ConnectionPassword"
> password but Ambari is pushing only to /etc/hive/conf.server/hive-site.xml. I
> have instructed and recommended various workarounds and even suggest modifying
> their app. Even having a static hive-site.xm with the information they did not
> accept and asked to open an enhancement request. The enhancement is to allow
> adding "javax.jdo.option.ConnectionPassword" to hive clients from ambari and
> have a separate hive-site.xml path for clients.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  622ee88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  349668f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  9a86827 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 4feba62 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> c30f28f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  931d58b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
>  61437d5 
>   ambari-server/src/main/resources/configuration-schema.xsd 0e17b0e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
>  229f7e1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
>  1743bf8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  0ff143c 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/configuration/hive-site.xml
>  5a3cb6c 
> 
> Diff: https://reviews.apache.org/r/49145/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to