-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/#review139298
-----------------------------------------------------------


Ship it!




Looks good apart from the minor typo to be addressed.


contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 (line 70)
<https://reviews.apache.org/r/48686/#comment204465>

    Minor typo. Should be ". Internal Error." - missing space after the dot.


- Hitesh Shah


On June 23, 2016, 9:14 p.m., Sreenath Somarajapuram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48686/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 9:14 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Hitesh Shah, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-17186
>     https://issues.apache.org/jira/browse/AMBARI-17186
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> More log messages would help us to debug EARs faster.
> 
> 
> Diffs
> -----
> 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
>  981353b 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ATSUrlFetchException.java
>  9eb7c47 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ActiveRMFetchException.java
>  cb6f2eb 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/ProxyException.java
>  aa006b2 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/TezWebAppException.java
>  PRE-CREATION 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
>  619f81e 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
>  97ee01d 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/utils/ProxyHelper.java
>  f642193 
> 
> Diff: https://reviews.apache.org/r/48686/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> Verified the presence of debug and error logs in 
> /var/log/ambari-server/tez-view/tez-view.log
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>

Reply via email to