-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49179/
-----------------------------------------------------------

(Updated June 24, 2016, 5:04 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17418
    https://issues.apache.org/jira/browse/AMBARI-17418


Repository: ambari


Description (updated)
-------

AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints 
and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor).

- LLAP configs will be calulated for when Stack Advisor calls is made by 
Blueprints where services["changed-configurations"] is empty.
- This is required when SA call is made by Blueprints and Hive Server 
Interactive (HSI) is ON, the LLAP calculations should happen. We detect that it 
is the BP call by checking services["changed-configurations"]  being empty.


- Also reverts AMBARI-17283. Display LLAP calculated configs as 'Labels' 
(non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in 
HIVE Advanced section.
  - This is causing a parity issue in terms of what values gets shown up in 
Advanced section (when user changes it) and what the *_copy   configs shows it 
in HSI panel, if user decides to discrd the value suggested by SA.
  - It is safe right now to revert this patch and let user change LLAP configs 
from HSI panel itself, as there will be only one point on display to know the 
current value and change it.


Diffs
-----

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 c2e1c0a 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 a0076b3 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
6b1d631 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py e4fad77 

Diff: https://reviews.apache.org/r/49179/diff/


Testing
-------

- Fixed Python UT's
- Added Python Ut for checking when services['changed-configurations'] is 
passed-in as empty.
- Pyython UT passes.


Thanks,

Swapan Shridhar

Reply via email to