-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
-----------------------------------------------------------




ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 100 - 
105)
<https://reviews.apache.org/r/49173/#comment204585>

    All graphs on Kafka-Topics have legend hidden.



ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 128 - 
133)
<https://reviews.apache.org/r/49173/#comment204586>

    All graphs on HBase-Users have legend hidden.
    
    We do need to handle this on aggregate level dashboards and graphs, and I 
already have a separate fix for that.


- Prajwal Rao


On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> -----------------------------------------------------------
> 
> (Updated June 24, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-17416
>     https://issues.apache.org/jira/browse/AMBARI-17416
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When there's no datapoint available, AMS Grafana plugin just ignores alias 
> and shows metric name instead. It seems to be not consistent in point of 
> view, and not good UX I think.
> 
> It'd be great AMS Grafana shows alias whenever there're datapoints available 
> or not.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b 
> 
> Diff: https://reviews.apache.org/r/49173/diff/
> 
> 
> Testing
> -------
> 
> Tested manually. Actually this is tiny fix so we can imagine how it will make 
> change.
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Reply via email to