> On June 24, 2016, 8:04 p.m., Alejandro Fernandez wrote: > > ambari-agent/etc/init.d/ambari-agent, line 22 > > <https://reviews.apache.org/r/49188/diff/1/?file=1429559#file1429559line22> > > > > These are only code comments, what's the fix?
Newer linux distributions use systemd for managing services. systemd supports the '/etc/init.d' scripts as well via 'insserv' but that requires this LSB section to be added to the start script of the service. Without this when someone executes 'update-rc.d ambari-server disable' to remove ambari to be restarted in case the host is rebooted the user will get an error: 'update-rc.d: error: ambari-server Default-Start contains no runlevels, aborting.' This is the format how Linux Standard Base has to be specified. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49188/#review139390 ----------------------------------------------------------- On June 24, 2016, 9:56 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49188/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 9:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Andrew Onischuk. > > > Bugs: AMBARI-17419 > https://issues.apache.org/jira/browse/AMBARI-17419 > > > Repository: ambari > > > Description > ------- > > Trying do disable auto-start for ambari-server by executing update-rc.d > ambari-server disable is failing with update-rc.d: error: ambari-server > Default-Start contains no runlevels, aborting. > > Added LSB to ambari-server and amabri-agent to define the default start and > stop levels > > > Diffs > ----- > > ambari-agent/etc/init.d/ambari-agent b2c3109 > ambari-server/sbin/ambari-server 72d94ed > > Diff: https://reviews.apache.org/r/49188/diff/ > > > Testing > ------- > > > Thanks, > > Sebastian Toader > >
