> On June 27, 2016, 12:42 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java, > > line 109 > > <https://reviews.apache.org/r/49253/diff/3/?file=1431002#file1431002line109> > > > > Why are we checking for a hard-coded value here? Are we assuming that > > no matter what schema is used, the "member" attribute will always mean the > > same thing?
you right, as I checked it, also uniqueMember is mostly DN too. so maybe better to make this configurable (and i'll keep the actual behavior)...this feature does not work anyway :) - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139560 ----------------------------------------------------------- On June 27, 2016, 11:59 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49253/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 11:59 a.m.) > > > Review request for Ambari, Daniel Gergely, Miklos Gergely, Robert Levas, and > Sandor Magyari. > > > Bugs: AMBARI-17444 > https://issues.apache.org/jira/browse/AMBARI-17444 > > > Repository: ambari > > > Description > ------- > > - extend check member value is a dn or not (it is possible that > userNameAttribute or groupNameAttribute does not appear in member value) > - make adminGroupMapping part of the BindAuthenticator more readable (+ make > it switchable) and fix if the memberAttribute is not dn > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java > c63ea92 > > ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java > 53ff16d > > ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java > 2265eec > > Diff: https://reviews.apache.org/r/49253/diff/ > > > Testing > ------- > > All green in apache report > > > Thanks, > > Oliver Szabo > >
