> On June 27, 2016, 3:45 p.m., Alexandr Antonenko wrote:
> > As I understand there was no issue with the logic that you changed?
> > If that is so, than why do we need this changes ?
> >
> > p.s. patch looks good and can be committed.
>
> Di Li wrote:
> Hello Alex,
>
> Thx for the review. A feedback I got from my text label translator is
> that the 'There were no {0}' is a better format for translating to other
> languages than concating two text label at the template level. So I changed
> the UI logic a bit. From display the label in English point of view, the
> current logic works just as well as the one I proposed.
>
> Thanks. Di
Oh I see. So there is information regarding new languages in ambari ? Because
as I know there is no plans to support any language other than eng in future
years
p.s. but anyway, please go ahead and commit
- Alexandr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49267/#review139580
-----------------------------------------------------------
On June 27, 2016, 3:31 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49267/
> -----------------------------------------------------------
>
> (Updated June 27, 2016, 3:31 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-17450
> https://issues.apache.org/jira/browse/AMBARI-17450
>
>
> Repository: ambari
>
>
> Description
> -------
>
> During host registration step on Ambari web UI, when a given check has no
> errors/warnings, UI displays 'There were no ....' label. The label right now
> is a concate of two labels at the handlebars template level.
>
> This JIRA moves the label generating logic to the view for the template to
> dispaly.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js d40a84a
> ambari-web/app/templates/wizard/step3/step3_host_warnings_popup.hbs 4b0f753
> ambari-web/app/views/wizard/step3/hostWarningPopupBody_view.js 5128ca3
>
> Diff: https://reviews.apache.org/r/49267/diff/
>
>
> Testing
> -------
>
> Build ambari rpms with the changes and run install, verify on the host
> registration step, the messages displayed are built at the view level.
>
>
> Thanks,
>
> Di Li
>
>
