> On June 27, 2016, 6:28 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 1650
> > <https://reviews.apache.org/r/49291/diff/1/?file=1431345#file1431345line1650>
> >
> >     Should probably make a less generic name. Also, shouldn't we allow any 
> > component auto-start to be specified?

1. Get the information from RecoveryConfig.java to determine if AUTO_START is 
enabled
2. If so, use this function, renamed to be specific, to update the components, 
also got from RecoveryConfig.java.


- Nahappan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49291/#review139711
-----------------------------------------------------------


On June 27, 2016, 5:24 p.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49291/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 5:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17455
>     https://issues.apache.org/jira/browse/AMBARI-17455
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector 
> after upgrade to 2.4.0
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  e029aea0e8f03a234907845b88339fbcc521bdbe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  0e4b4ebae0a9c00af41a0a619b3c3823183b3657 
> 
> Diff: https://reviews.apache.org/r/49291/diff/
> 
> 
> Testing
> -------
> 
> **1. mvn clean install **
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [9.253s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.038s]
> [INFO] Ambari Web ........................................ SUCCESS [1:16.822s]
> [INFO] Ambari Views ...................................... SUCCESS [1.464s]
> [INFO] Ambari Admin View ................................. SUCCESS [12.551s]
> [INFO] ambari-metrics .................................... SUCCESS [0.813s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.938s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.402s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.644s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.693s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.761s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [10.824s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.416s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [0.879s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:33.158s]
> [INFO] Ambari Server ..................................... SUCCESS [3:18.311s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [2.758s]
> [INFO] Ambari Agent ...................................... SUCCESS [30.935s]
> [INFO] Ambari Client ..................................... SUCCESS [0.070s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.127s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.264s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.060s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.811s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.296s]
> [INFO] ambari-logsearch .................................. SUCCESS [0.636s]
> [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.444s]
> [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [5.905s]
> [INFO] Ambari Logsearch Portal ........................... SUCCESS [6.169s]
> [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [3.200s]
> [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.119s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 7:48.476s
> [INFO] Finished at: Mon Jun 27 17:03:45 PDT 2016
> [INFO] Final Memory: 335M/1302M
> [INFO] 
> ------------------------------------------------------------------------
> 
> ** 2. mvn test -DskipPythonTests -Dtest=UpgradeCatalog240Test **
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.447 sec - 
> in org.apache.ambari.server.upgrade.UpgradeCatalog240Test
> 
> Results :
> 
> Tests run: 28, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 39.656s
> [INFO] Finished at: Mon Jun 27 17:23:01 PDT 2016
> [INFO] Final Memory: 55M/913M
> [INFO] 
> ------------------------------------------------------------------------
> 
> ** 3. Manual tests **
> 
> Installed a single node cluster with ambari 2.2.2 and upgraded it to ambari 
> 2.4.0 with the ambari-server JAR from the local build and verified that 
> *servicecomponentdesiredstate* table had *recovery_enabled* set to *1* for 
> *METRICS_COLLECTOR*
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to