----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49291/#review139929 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (line 2694) <https://reviews.apache.org/r/49291/#comment205266> Rename to getRecoveryEnabledComponents ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (line 1657) <https://reviews.apache.org/r/49291/#comment205267> LowerCase on method name ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (line 1731) <https://reviews.apache.org/r/49291/#comment205268> This looks dangerous, do we enable all if config is absent? I thought only METRICS_COLLECTOR is auto-start enabled. ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (line 1736) <https://reviews.apache.org/r/49291/#comment205271> regex looks weird since it matches whitespace around comma. ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java (line 1749) <https://reviews.apache.org/r/49291/#comment205272> Is this reachable ? - Sid Wagle On June 28, 2016, 8:11 p.m., Nahappan Somasundaram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49291/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 8:11 p.m.) > > > Review request for Ambari, Ajit Kumar, Aravindan Vijayan, Sumit Mohanty, and > Sid Wagle. > > > Bugs: AMBARI-17455 > https://issues.apache.org/jira/browse/AMBARI-17455 > > > Repository: ambari > > > Description > ------- > > AMBARI-17455: Auto restart flag should be set to 1 for Metrics Collector > after upgrade to 2.4.0 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 153289e40cfe67bba0931548b282416de453a980 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > e029aea0e8f03a234907845b88339fbcc521bdbe > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 0e4b4ebae0a9c00af41a0a619b3c3823183b3657 > > Diff: https://reviews.apache.org/r/49291/diff/ > > > Testing > ------- > > **1. mvn clean install ** > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [8.253s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.039s] > [INFO] Ambari Web ........................................ SUCCESS [26.604s] > [INFO] Ambari Views ...................................... SUCCESS [1.359s] > [INFO] Ambari Admin View ................................. SUCCESS [7.969s] > [INFO] ambari-metrics .................................... SUCCESS [0.732s] > [INFO] Ambari Metrics Common ............................. SUCCESS [0.889s] > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.330s] > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.623s] > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.661s] > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.646s] > [INFO] Ambari Metrics Collector .......................... SUCCESS [11.730s] > [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.428s] > [INFO] Ambari Metrics Grafana ............................ SUCCESS [1.000s] > [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:30.749s] > [INFO] Ambari Server ..................................... SUCCESS [3:20.686s] > [INFO] Ambari Functional Tests ........................... SUCCESS [1.301s] > [INFO] Ambari Agent ...................................... SUCCESS [28.486s] > [INFO] Ambari Client ..................................... SUCCESS [0.064s] > [INFO] Ambari Python Client .............................. SUCCESS [1.076s] > [INFO] Ambari Groovy Client .............................. SUCCESS [2.448s] > [INFO] Ambari Shell ...................................... SUCCESS [0.046s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.814s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [1.108s] > [INFO] ambari-logsearch .................................. SUCCESS [0.313s] > [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.435s] > [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.190s] > [INFO] Ambari Logsearch Portal ........................... SUCCESS [6.929s] > [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [3.005s] > [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.123s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 6:44.743s > [INFO] Finished at: Tue Jun 28 12:49:06 PDT 2016 > [INFO] Final Memory: 326M/1346M > [INFO] > ------------------------------------------------------------------------ > > ** 2. mvn test -DskipPythonTests -Dtest=UpgradeCatalog240Test ** > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > Running org.apache.ambari.server.upgrade.UpgradeCatalog240Test > Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.447 sec - > in org.apache.ambari.server.upgrade.UpgradeCatalog240Test > > Results : > > Tests run: 28, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 39.379s > [INFO] Finished at: Tue Jun 28 13:04:18 PDT 2016 > [INFO] Final Memory: 55M/908M > [INFO] > ------------------------------------------------------------------------ > > ** 3. Manual tests ** > > Installed a single node cluster with ambari 2.2.2 and upgraded it to ambari > 2.4.0 with the ambari-server JAR from the local build and verified that > *servicecomponentdesiredstate* table had *recovery_enabled* set to *1* for > all the components in the *recovery.enabled_components* property in > ambari.properties. > > Also verified that *clusterconfig* table was updated with a new row for > configuration type *cluster-env* from the recovery settings from > ambari.properties. > > > Thanks, > > Nahappan Somasundaram > >
