> On June 29, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java,
> >  line 20
> > <https://reviews.apache.org/r/49260/diff/2/?file=1431867#file1431867line20>
> >
> >     Are changes to this file purely refactoring or addition of new tests? 
> > If its just refactoring then lets do it in trunk or branch-2.4 only.

As the initial code change was in the AmbariCustomCommandExecutionHelper i 
thougth this test class needs to be modified / extended with new tests. As it 
was easier / quicker to add assertions to the existing test i gave up adding a 
new test here, but i have already removed mockito dependencies and used 
easymock instead (afaik easymock is what we use for testing)


> On June 29, 2016, 1:20 a.m., Sumit Mohanty wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java,
> >  line 324
> > <https://reviews.apache.org/r/49260/diff/2/?file=1431867#file1431867line324>
> >
> >     Any reason the verify construct was removed?

I have changed the test framework from Mockito to EasyMock. The test "logic" 
didn't change at all.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49260/#review139909
-----------------------------------------------------------


On June 28, 2016, 2:09 p.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49260/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 2:09 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-17313
>     https://issues.apache.org/jira/browse/AMBARI-17313
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem:
> In case services / components are restarted, their desired states are not 
> changed. As during restart -per definition- services are expected to be in 
> STARTED state this should be OK, however if the restart is triggered for 
> services in STOPPED state this causes problems (The UI allows triggering 
> restart for stopped services). (Eg.: recovery manager doesn't bring them back 
> to running state)
> 
> Solution:
> When assembling the RESTART custom command desired states of affected 
> services are updated to STARTED.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b60592d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  68b31c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  fd70df5 
> 
> Diff: https://reviews.apache.org/r/49260/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on dev-env.
> 
> Unit tests running ....
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Reply via email to