-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49162/#review140026
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 203)
<https://reviews.apache.org/r/49162/#comment205351>

    Use os.path.join



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 (line 204)
<https://reviews.apache.org/r/49162/#comment205352>

    Use a try except and always close the file in the finally block



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 144)
<https://reviews.apache.org/r/49162/#comment205349>

    Just check for len > 0



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 148)
<https://reviews.apache.org/r/49162/#comment205350>

    We should really give these default values right before the if-block to 
make sure if anyone refactors this code that these variables are always 
initialized


- Alejandro Fernandez


On June 28, 2016, 5:28 p.m., Renjith Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49162/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 5:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17406
>     https://issues.apache.org/jira/browse/AMBARI-17406
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - comment session manager config in shiro.ini
> - fix default value for zeppelin kerberos properties
> - extract kerberos config update to a new function
> - prevent overwriting interpreter config
> - set default value for spark and livy master
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  844ae98 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  f2899d0 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  770f8f5 
> 
> Diff: https://reviews.apache.org/r/49162/diff/
> 
> 
> Testing
> -------
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Reply via email to