-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review140029
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 (line 377)
<https://reviews.apache.org/r/49072/#comment205353>

    Please use a constant at least and a code comment that it is currently 
hardcoded (including the file and line number on the backend side).
    
    We should make it easier to change any hardcodings we introduce.


- Alejandro Fernandez


On June 28, 2016, 6:08 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 6:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
>     https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> -------
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to