-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49324/#review140035
-----------------------------------------------------------




contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 146)
<https://reviews.apache.org/r/49324/#comment205359>

    Use pythonic_variable_names



contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 267)
<https://reviews.apache.org/r/49324/#comment205360>

    Please add PyDoc for longer functions



contrib/utils/preinstall-check/src/main/python/preinstall_checker.py (line 822)
<https://reviews.apache.org/r/49324/#comment205358>

    python comments are double quoted inside the function


- Alejandro Fernandez


On June 28, 2016, 4:15 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49324/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17352
>     https://issues.apache.org/jira/browse/AMBARI-17352
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is a new utility Python script that I would like to include as part of 
> the contrib project.
> 
> Ambari web UI runs host checks during host (ambari agent) registration. For 
> users that run blueprint install, it would be nice if Ambari ships with a 
> command line script that runs host checks and summarize the results.
> 
> 
> Diffs
> -----
> 
>   contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49324/diff/
> 
> 
> Testing
> -------
> 
> run python script against a cluster with only ambari server and agents 
> installed. the python script prints out the same check results as the UI on 
> the host registration page.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to