> On June 29, 2016, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/setupMpacks.py, line 326
> > <https://reviews.apache.org/r/49328/diff/1/?file=1431989#file1431989line326>
> >
> >     Please add some more comments for what this does.

I've added the same level of comments as was originally added in the delivery 
of the setupMpacks.py file which does the exact same thing for stacks and addon 
services.  I can add more comments specifically for the new extensions code but 
really all of the functions should include more.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49328/#review140034
-----------------------------------------------------------


On June 28, 2016, 5:11 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49328/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 5:11 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17465
>     https://issues.apache.org/jira/browse/AMBARI-17465
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently management packs (AMBARI-14854) can only add stacks and addon 
> services. Now that AMBARI-12885 has been resolved, the management packs 
> should be able to add extensions as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py e868f96 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 98811f5 
> 
> Diff: https://reviews.apache.org/r/49328/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> ambari-server install-mpack --mpack=/root/mpacks/my-extension-1.0.0.0.tar.gz 
> -v
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Reply via email to