----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49383/#review140154 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java (line 134) <https://reviews.apache.org/r/49383/#comment205457> I think this can be made ```final``` as it's being initialised from constructor. Also if this map shouldn't be changed once initialised let's make it immutable (guava's ImmutableMap provides easy functions for easily create and populate immutable maps). - Sebastian Toader On June 29, 2016, 6:14 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49383/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 6:14 p.m.) > > > Review request for Ambari, Laszlo Puskas, Sebastian Toader, and Vitalyi > Brodetskyi. > > > Repository: ambari > > > Description > ------- > > Add a validation of required services during a blueprint deployment. > Currently a blueprint deployment allows to install YARN without HDFS. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java > 16f75ee > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > de5e2b3 > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java > b85d454 > > Diff: https://reviews.apache.org/r/49383/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >