-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49438/#review140199
-----------------------------------------------------------




ambari-server/src/test/python/stacks/utils/RMFTestCase.py (line 303)
<https://reviews.apache.org/r/49438/#comment205512>

    isinstance(x, str) is also supported in python 2.*


- Alejandro Fernandez


On June 30, 2016, 1:50 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49438/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 1:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Miklos 
> Gergely, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17499
>     https://issues.apache.org/jira/browse/AMBARI-17499
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - we can upload the whole solr config folder on bootsrapping logsearch or 
> atlas, but later we cannot really edit it
> -> add abillity to reupload solrconfig.xml (but no any change in solr 
> schema), but only if solrconfig.xml content is provided
> 
> add some refactoring too for solr_cloud_util:
> - its not needed to generate a random number for solr_cloud_util
> - its not needed to generate a tmp folder name (where ambari downloads the 
> solr config)
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  038f64d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a34925f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> ffa9e13 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  bfab139 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  e35ea5f 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1109e51 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 48e071d 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 65bd1d2 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> 10c40f4 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 53a854c 
> 
> Diff: https://reviews.apache.org/r/49438/diff/
> 
> 
> Testing
> -------
> 
> Total run:1086
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to