-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49476/#review140272
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On June 30, 2016, 10:35 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49476/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 10:35 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Zhe (Joe) Wang, Richard Zang, 
> Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17283
>     https://issues.apache.org/jira/browse/AMBARI-17283
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server 
> Interactive' Panel and Textboxes (editable) in HIVE Advanced section.
> 
> Following configs need to be shown as Labels on Hive Server Interactive Panel.
> hive-interactive-site/hive.llap.daemon.yarn.container.mb
> hive-interactive-site/hive.llap.daemon.num.executors
> hive-interactive-site/hive.llap.io.memory.size
> hive-interactive-env/num_llap_nodes
> User will have the option to edit them on HIVE Advanced page.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  931d58b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  c6cb873 
>   ambari-web/app/controllers/main/service/info/configs.js bc91b72 
>   ambari-web/app/mappers/configs/themes_mapper.js a2bfd99 
>   ambari-web/app/models/configs/objects/service_config_property.js 73960b3 
>   ambari-web/app/utils/config.js a9cb5e9 
>   ambari-web/app/views/common/configs/widgets/config_widget_view.js 86ae3f3 
>   ambari-web/test/controllers/main/service/info/config_test.js 1c8cbfd 
> 
> Diff: https://reviews.apache.org/r/49476/diff/
> 
> 
> Testing
> -------
> 
> Verified on deployed cluster that the patch resolves the issue.
> Verified that all ambari-web unit tests passes with the patch:
> 28937 tests complete (29 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to