----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140350 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py (line 115) <https://reviews.apache.org/r/49510/#comment205734> Since you have already initilized hive_* (line 101-104) properties you don't need else condition. ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py (line 124) <https://reviews.apache.org/r/49510/#comment205735> Same here, this else is also redundant. - Prabhjyot Singh On July 1, 2016, 1:52 p.m., Renjith Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49510/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 1:52 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17523 > https://issues.apache.org/jira/browse/AMBARI-17523 > > > Repository: ambari > > > Description > ------- > > - remove Livy component dependency from metainfo.xml > - code clean up > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml > 4f19b43 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > fd6cbb6 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 936df81 > > Diff: https://reviews.apache.org/r/49510/diff/ > > > Testing > ------- > > manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
