-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49513/#review140366
-----------------------------------------------------------



Don't we need change in AMSReportPropertyProvider, I thought some of the Host 
calls go to the RPP, if not igore this comment.


ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 (line 228)
<https://reviews.apache.org/r/49513/#comment205752>

    Consider rename to hostNamesBatch



ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 (line 460)
<https://reviews.apache.org/r/49513/#comment205753>

    Consider rename to splitHostnamesInBatches.


- Sid Wagle


On July 1, 2016, 3:16 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49513/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 3:16 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17526
>     https://issues.apache.org/jira/browse/AMBARI-17526
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> http://<ambari_host>:8080/api/v1/clusters/<cluster_name>?fields=hosts/* no 
> longer returns the metrics for the hosts.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  9a7454c 
>   ambari-server/src/main/resources/ganglia_properties.json 05360da 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  c7dabf1 
> 
> Diff: https://reviews.apache.org/r/49513/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to