> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-storm-sink/pom.xml, line 35
> > <https://reviews.apache.org/r/49514/diff/1/?file=1434990#file1434990line35>
> >
> >     Since this isn't apache version, checking this in will break apache 
> > builds ?

Yes it will. we need storm-core 1.0.1.2.5.0.0-830 in public maven repo before 
commiting


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 30
> > <https://reviews.apache.org/r/49514/diff/1/?file=1434997#file1434997line30>
> >
> >     So both old and new properties are ok to be present at the same time?

yes


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py,
> >  line 96
> > <https://reviews.apache.org/r/49514/diff/1/?file=1435000#file1435000line96>
> >
> >     No check for stack name?

I'll fix


> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java,
> >  line 194
> > <https://reviews.apache.org/r/49514/diff/1/?file=1434988#file1434988line194>
> >
> >     Good catch, however, why not look for "._" and replace that only if 
> > needed.

There is no change here. It's a copy of previous StormTimelineMetricsSink.java


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140370
-----------------------------------------------------------


On Июль 1, 2016, 3:32 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> -----------------------------------------------------------
> 
> (Updated Июль 1, 2016, 3:32 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
>     https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> -------
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to