-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49557/#review140496
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py (line 
99)
<https://reviews.apache.org/r/49557/#comment205894>

    Lets split it for readability
    enclose the whole logic under "if hiveServerHost is not None"
    
    Why does schema name matter?
    
    Do we need to read oldDBType - if its not set would 
firstPartofDBConnectionURL be non None?



ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py (line 
193)
<https://reviews.apache.org/r/49557/#comment205893>

    Rename it to getProtocol?



ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py (line 210)
<https://reviews.apache.org/r/49557/#comment205895>

    Can we add one test with the value changed by stack advisor?


- Sumit Mohanty


On July 2, 2016, 4:29 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49557/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 4:29 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17491
>     https://issues.apache.org/jira/browse/AMBARI-17491
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack advisor recommeds to update host in Hive/Oozie db connection url when 
> we don't need that.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py 
> 3d6ca4c 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> abea76e 
> 
> Diff: https://reviews.apache.org/r/49557/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to