> On 7 1, 2016, 5:09 오후, Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml,
> >  line 40
> > <https://reviews.apache.org/r/49514/diff/1/?file=1434997#file1434997line40>
> >
> >     Does the parallelism = 1, mean 1 bolt getting all metric reports in a 
> > topology. Is it counter-intuitive for performance, something we should 
> > check with storm group.
> 
> Jungtaek Lim wrote:
>     Its default value has been 1, so setting it explicitly means letting 
> users to modify it easily.
> 
> Sriharsha Chintalapani wrote:
>     this is tricky config. We should expose this in ambari config page 
> otherwise most users wouldn't notice that a metrics bolt running and can 
> cause perf degradation if they go with 1 parallelism to prod.

With asynchronous metrics consumer bolt, this could be not a big deal in point 
of performance view. 
We already did performance test with slow metrics consumer, and test showed 
that topology performance is not affected (or small portion) by consumer bolt.
https://github.com/apache/storm/pull/1324#issuecomment-218962460

But I also agree that it's worth to notice users that metrics bolt is running. 
Users can increase paralellism when consumer can't keep up metrics, or applying 
filters, or even discard this configuration to not use metrics consumer at all. 
In order to do that, users should know where is the config, and what's default 
value of the config.


- Jungtaek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140384
-----------------------------------------------------------


On 7 3, 2016, 1:23 오후, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> -----------------------------------------------------------
> 
> (Updated 7 3, 2016, 1:23 오후)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
>     https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  8f98563 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0ef09d6 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  4ea7396 
>   ambari-metrics/pom.xml 726a823 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  ea8b1d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> f7a2686 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> -------
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to