-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49249/
-----------------------------------------------------------

(Updated 7 4, 2016, 12:23 오후)


Review request for Ambari, Aravindan Vijayan, Prajwal Rao, Sriharsha 
Chintalapani, and Sid Wagle.


Changes
-------

Also applied changeset to legacy sink. (Rebased to recent trunk)


Bugs: AMBARI-17445
    https://issues.apache.org/jira/browse/AMBARI-17445


Repository: ambari


Description
-------

With AMBARI-16946 we expanded metric name to have component name, task id, and 
key when type of metric value is Map. Topology name was placed to appId.

While talking with Prajwal Rao and sriharsha chintalapani, we found that we 
should move out all necessary informations like topology name, worker host, 
worker port to metric name so that they can be templatized.

This also supercedes AMBARI-17249 since all metrics will include worker host 
and worker port to metric name.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 9266e5f 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 4ea7396 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 d04bc15 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 3e9ed34 

Diff: https://reviews.apache.org/r/49249/diff/


Testing
-------

Tested locally. Attached screenshot to origin issue.
https://issues.apache.org/jira/secure/attachment/12813582/AMBARI-17445-changes.png


Thanks,

Jungtaek Lim

Reply via email to