-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49539/#review140672
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 (line 279)
<https://reviews.apache.org/r/49539/#comment206033>

    Should return 0 after this line.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 (line 281)
<https://reviews.apache.org/r/49539/#comment206034>

    We don't need this else condition



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 (line 282)
<https://reviews.apache.org/r/49539/#comment206035>

    This check should be done all the time when alias is created. So it should 
be outside the else condition


- Don Bosco Durai


On July 1, 2016, 11:04 p.m., Don Bosco Durai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49539/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17541
>     https://issues.apache.org/jira/browse/AMBARI-17541
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Creating solr colection alias with audit_logs and ranger_audits
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  f1789c1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  3a1a1ca 
> 
> Diff: https://reviews.apache.org/r/49539/diff/
> 
> 
> Testing
> -------
> 
> Tested in 3 node ambari cluster
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Reply via email to