-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49626/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-17559
    https://issues.apache.org/jira/browse/AMBARI-17559


Repository: ambari


Description
-------

1) If a command gets aborted, it remains in "IN_PROGRESS" state on the agent. 
Agent sends it in each heartbeat until agent gets restarted.

2) Because of an ordering issue in the heartbeat report processing, server 
sometimes mismatches command statuses. (If we have COMPLETED command and 
ABORTED in the same heartbeat, it may think that completed command was aborted 
and rejects state change). This situation was rare previously, but because of 
the first issue aborted commands come in each Heartbeat.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 3832b81 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java
 2b121dc 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 c6036c2 
  ambari-server/src/main/java/org/apache/ambari/server/utils/CommandUtils.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
 50021c2 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
 f85b95d 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 e0f67af 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 913c4ea 

Diff: https://reviews.apache.org/r/49626/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Reply via email to