-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48855/#review140829
-----------------------------------------------------------




ambari-web/app/controllers/global/cluster_controller.js (line 309)
<https://reviews.apache.org/r/48855/#comment206162>

    If an upgrade is paused, I believe the state will be ABORTED. Try checking 
that scenario.


- Alejandro Fernandez


On July 5, 2016, 5:07 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48855/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 5:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, 
> Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12697
>     https://issues.apache.org/jira/browse/AMBARI-12697
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari UI shows operation history in the ops prompt. All upgrade and 
> downgrade attempts are not shown on the UI once user finalizes it and close 
> the upgrade/downgrade UI.
> 
> The information is in the database already. This JIRA is to propose a way to 
> add UI elements to display a list of upgrades/downgrades associated with the 
> cluster, including both express and rolling ones.
> 
> UI BEHAVIOR:
> 
> 1. The new tab is the "Upgrade History" tabe shown on the Version and Stack 
> page. Users will see three tabs now, the Version tab, the Stack tab and the 
> Upgrade History tab. 
> 2. The Upgrade History tab shows a filter widget and a table showing the list 
> of upgrades/downgrades based on the filter select. Default filter select is 
> 'All', so all upgrade and downgrade records from the Ambari database 
> (upgrades tables) are shown on the UI. 
> 3. User clicks on a given record to open the detail view popup dialog that 
> resembles the upgrade wizard UI. on the detail view popup dialog, user can 
> drill up and down on upgrade steps for details.
> 
> UI SCREENSHOT:
> 1. Upgrade_History view: 
> https://issues.apache.org/jira/secure/attachment/12811384/Upgrade_History_view.png
> 2. Upgrade details view: 
> https://issues.apache.org/jira/secure/attachment/12811385/Upgrade_Details_view.png
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 005c97b 
>   ambari-web/app/controllers.js 2537f62 
>   ambari-web/app/controllers/global/cluster_controller.js 0d9d41d 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> PRE-CREATION 
>   ambari-web/app/mappers.js 96193bc 
>   ambari-web/app/mappers/stack_upgrade_history_mapper.js PRE-CREATION 
>   ambari-web/app/messages.js dcf0426 
>   ambari-web/app/models.js b877255 
>   ambari-web/app/models/finished_upgrade_entity.js PRE-CREATION 
>   ambari-web/app/models/stack_version/stack_upgrade_history.js PRE-CREATION 
>   ambari-web/app/routes/main.js 8d33a68 
>   ambari-web/app/styles/stack_versions.less 604b655 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history.hbs 
> PRE-CREATION 
>   
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_history_details.hbs 
> PRE-CREATION 
>   ambari-web/app/views.js ab79b98 
>   ambari-web/app/views/main/admin/stack_upgrade/menu_view.js 1e84f1c 
>   
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 
> PRE-CREATION 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 
> PRE-CREATION 
>   
> ambari-web/test/controllers/main/admin/stack_upgrade_history_controller_test.js
>  PRE-CREATION 
>   ambari-web/test/mappers/stack_upgrade_history_mapper_test.js PRE-CREATION 
>   ambari-web/test/models/finished_upgrade_entity_test.js PRE-CREATION 
>   
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_history_details_view_test.js
>  PRE-CREATION 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_history_view_test.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48855/diff/
> 
> 
> Testing
> -------
> 
> 1. patch a trunk cluster with the code change, ran express upgrades, express 
> downgrades, rolling upgrades and rolling downgrades. Check upgrade and 
> downgrade history displayed on the UI
> 2. new unit tests
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to