-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49711/
-----------------------------------------------------------

Review request for Ambari, Ajit Kumar and Sumit Mohanty.


Bugs: AMBARI-17593
    https://issues.apache.org/jira/browse/AMBARI-17593


Repository: ambari


Description
-------

AMBARI-17593: Ambari server backup error - failure if backup size exceeds 4GB

** Issue: **
If the size of the archive exceeds, zipping fails

** Fix: **
Specify allowZip64=True when calling ZipFile


Diffs
-----

  ambari-server/src/main/python/ambari_server/BackupRestore.py 
2c00be9915a0b81cbb6be38f7c09fd58c5ca3d12 

Diff: https://reviews.apache.org/r/49711/diff/


Testing
-------

**1. mvn clean install **

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [11.210s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.039s]
[INFO] Ambari Web ........................................ SUCCESS [33.914s]
[INFO] Ambari Views ...................................... SUCCESS [1.327s]
[INFO] Ambari Admin View ................................. SUCCESS [8.895s]
[INFO] ambari-metrics .................................... SUCCESS [0.713s]
[INFO] Ambari Metrics Common ............................. SUCCESS [3.857s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.111s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.232s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.216s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [24.618s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.642s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [11.834s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [3.307s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [0.990s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:30.657s]
[INFO] Ambari Server ..................................... SUCCESS [2:58.533s]
[INFO] Ambari Functional Tests ........................... SUCCESS [2.605s]
[INFO] Ambari Agent ...................................... SUCCESS [27.833s]
[INFO] Ambari Client ..................................... SUCCESS [0.058s]
[INFO] Ambari Python Client .............................. SUCCESS [0.948s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.109s]
[INFO] Ambari Shell ...................................... SUCCESS [0.037s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.667s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.944s]
[INFO] ambari-logsearch .................................. SUCCESS [0.265s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.427s]
[INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.090s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [6.379s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [14.708s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.087s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7:16.379s
[INFO] Finished at: Wed Jul 06 09:42:57 PDT 2016
[INFO] Final Memory: 335M/1134M
[INFO] ------------------------------------------------------------------------

** 2. mvn test -DskipSurefireTests **

----------------------------------------------------------------------
Ran 261 tests in 6.676s

OK
----------------------------------------------------------------------
Total run:1014
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:07.864s
[INFO] Finished at: Wed Jul 06 09:48:34 PDT 2016
[INFO] Final Memory: 55M/918M
[INFO] ------------------------------------------------------------------------

**3. Manual tests **

Added a few SQL dump files with sizes totalling over 4GB to /etc/ folder and 
verified that ambari-server backup succeeded.


Thanks,

Nahappan Somasundaram

Reply via email to