----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49735/#review141106 -----------------------------------------------------------
Ship it! Ship It! - Juanjo Marron On July 6, 2016, 11:45 p.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49735/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 11:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo > Marron. > > > Bugs: AMBARI-17570 > https://issues.apache.org/jira/browse/AMBARI-17570 > > > Repository: ambari > > > Description > ------- > > Some of the *_client.py files (e.g. > ambari/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py) > don't import ClientComponentHasNoStatus while it is used. It should be > imported. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py > 1e7ed1f3 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > f8c33dd > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 93d244d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py > 1f85fc0 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > 5a398db > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py > 7c5b6e0 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py > 111f4d2 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py > 99314ec > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py > fac92e1 > > Diff: https://reviews.apache.org/r/49735/diff/ > > > Testing > ------- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12816319/AMBARI-17570.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/7710//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/7710//console > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
