-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49691/
-----------------------------------------------------------

(Updated July 8, 2016, 6:45 a.m.)


Review request for Ambari, Alejandro Fernandez, Nahappan Somasundaram, and 
Sumit Mohanty.


Changes
-------

Replaced "skip_failure" in AmbariManagementControllerImpl.java and 
HostComponentResourceProvider.java  with Setting.SETTING_NAME_SKIP_FAILURE.


Bugs: AMBARI-17599
    https://issues.apache.org/jira/browse/AMBARI-17599


Repository: ambari


Description
-------

Currently if a cluster deployment is scheduled and any install/start task 
fails, all other queued tasks are cancelled. Ideally it should be possible for 
user to pass a flag to skip failures for best effort deployment instead of 
failing fast on error.

While creating a blueprint json, user can provide deployment settings as 
follows :

"settings" : [
  {
  "deployment_settings" : [{
      "skip_failure" : "true"
   }]
  }
]


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 aaf69df 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 9d8389a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 de7f209 
  
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
 c6279bc 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
 926d253 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
0edbaea 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
 aeb9a2d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
 3cdca4d 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 cee9406 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
a9c26cc 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
 7ec6088 
  ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 
c03d833 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
 4444714 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 0b06eb8 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithHostsSyspreppedTest.java
 d49c21d 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 ad441e4 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
 e979173 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java 
5615d12 

Diff: https://reviews.apache.org/r/49691/diff/


Testing
-------

Tested manually by creating a cluster with blueprint (attached). It has 
deployment_settings as follows
"settings" : [
  {
  "deployment_settings" : [{
      "skip_failure" : "true"
   }]
  }
]

mvn test

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [8.590s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.024s]
[INFO] Ambari Web ........................................ SUCCESS [37.028s]
[INFO] Ambari Views ...................................... SUCCESS [3.221s]
[INFO] Ambari Admin View ................................. SUCCESS [14.033s]
[INFO] ambari-metrics .................................... SUCCESS [0.507s]
[INFO] Ambari Metrics Common ............................. SUCCESS [9.610s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [5.440s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [7.033s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [3.401s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.075s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.573s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [8:00.318s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [1.513s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [0.744s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [2.746s]
[INFO] Ambari Server ..................................... SUCCESS [59:14.115s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1.808s]
[INFO] Ambari Agent ...................................... SUCCESS [23.211s]
[INFO] Ambari Client ..................................... SUCCESS [0.029s]
[INFO] Ambari Python Client .............................. SUCCESS [0.389s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.331s]
[INFO] Ambari Shell ...................................... SUCCESS [0.023s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [8.679s]
[INFO] ambari-logsearch .................................. SUCCESS [0.143s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.145s]
[INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.935s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [0.913s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [13.400s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.086s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:09:54.830s
[INFO] Finished at: Thu Jul 07 11:05:16 PDT 2016
[INFO] Final Memory: 121M/1001M
[INFO] ------------------------------------------------------------------------


File Attachments
----------------

blueprint.json
  
https://reviews.apache.org/media/uploaded/files/2016/07/07/03db77b8-7fba-48c3-b34b-5dcb75e217b7__blueprint.json


Thanks,

Ajit Kumar

Reply via email to