-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49898/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely, Robert Levas, Robert Nettleton, 
Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-17653
    https://issues.apache.org/jira/browse/AMBARI-17653


Repository: ambari


Description
-------

Add abillity to use jaas file to authenticate on znode. (that was missing in 
upload configuration to zk)
- Get rid of zkcli of Solr (we can manage everything from solr-client, that 
will be useful, later we can use Watchers with async zookeeper command, which 
can wait until a znode is accessible etc.)
- add new functionalities for solrCloudCli (and solr_cloud_util) like 
setup_kerberos and add_sasl_users, with those we can copy all of the data 
between secure/unsecure znodes (sync...its needed because we have strict 
permissions, but if we disable kerberos we can not change them back), and we 
can create new sasl users. (also it set workd permission on secure node)...in 
the end I not use these features in ambari, using 2 znode (as hbase does) is a 
bit tricky solution. we have some other components where we are not using 
secure zookeeper. if we can find a good solution there later then I can use 
these features (or change them if needed....like, it would be good if we can 
use a zk super user...in that case we do not need to switch between znodes)
- user state json file to track what is the state of the cluster 
(secure/unsecure), that is used to figure it out an enable/disable kerberos 
task happening or there is not state change at all
- remove a lot of unused j2 file from logsearch module
- add retries for atlas/ranger if solr or znode not accessible
- better error messages for timing errors


Diffs
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4ecddf2 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
3428dd8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/global.config.json.j2
 cd51118 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/input.config.json.j2
 bc48503 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml.j2 
4338ee3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2
 63c590e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh.j2 
713a73a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml.j2
 cb9bea5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/core.properties.j2
 5185057 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/solrconfig.xml.j2
 0152880 
  ambari-logsearch/ambari-logsearch-portal/src/main/resources/log4j.xml.j2 
3b6eac9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 8e3966e 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh.j2 cb78c58 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml bc3babe 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 1e3cca5 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 33e94d0 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 de90859 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractStateFileZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperConfigCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java
 c9e8558 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java
 819395c 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSolrZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java
 2a0fa31 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/EnableKerberosPluginSolrZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetStateFileZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureZNodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SetClusterPropertyZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UpdateStateFileZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java
 466f8ca 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/domain/AmbariSolrState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties
 e8fedce 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 d75e87d 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 ba3f460 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 d656012 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
 ff10165 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 051310e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
0da6e4d 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 0ef54f3 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 1120743 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 4425151 

Diff: https://reviews.apache.org/r/49898/diff/


Testing
-------

FT; kerberize/unkerberize 4 node cluster, check acls with sasl users only 
(restrict "world:anyone" ... then set the permission back with zookeeper 
superuser)

UT:
Total run:1017
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Reply via email to