-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49905/#review141727
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On July 11, 2016, 5:27 p.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49905/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 5:27 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17645
>     https://issues.apache.org/jira/browse/AMBARI-17645
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Dockerfile in dev-support uses Java 7 while its support is finished. It 
> would be nice it is Java 8 for developing purpose.
> 
> 
> Diffs
> -----
> 
>   dev-support/docker/docker/Dockerfile 802d20a 
> 
> Diff: https://reviews.apache.org/r/49905/diff/
> 
> 
> Testing
> -------
> 
> Hadooop QAed & manual tests done
> 
> ```
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to