-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49927/#review141783
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 
<https://reviews.apache.org/r/49927/#comment207154>

    These properties will be calculated on the python side instead, no need to 
have them show up on the UI.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 35)
<https://reviews.apache.org/r/49927/#comment207155>

    This is the important logic



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 64)
<https://reviews.apache.org/r/49927/#comment207156>

    What if the user already has the property atlas.server.ha.enabled, then 
only allow setting it to true if they don't change it to false and they have 
multiple Atlas servers.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 
<https://reviews.apache.org/r/49927/#comment207157>

    Already defined in status_params.py



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 
<https://reviews.apache.org/r/49927/#comment207158>

    This was dead code, it did nothing



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 (line 32)
<https://reviews.apache.org/r/49927/#comment207159>

    Will remove this.


- Alejandro Fernandez


On July 11, 2016, 9:38 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49927/
> -----------------------------------------------------------
> 
> (Updated July 11, 2016, 9:38 p.m.)
> 
> 
> Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit 
> Mohanty, and Suma Shivaprasad.
> 
> 
> Bugs: AMBARI-17662
>     https://issues.apache.org/jira/browse/AMBARI-17662
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Deploy multiple Atlas servers and one of them will fail since it will be 
> missing its ids.
> 
> To fix this,
> 
> atlas.server.ha.enabled will not be shown on the UI and instead derived. But 
> if for whatever reason we need to do some debugging/troubleshooting on Atlas, 
> we may allow the user to override the property.
> 
> * single Atlas Server => write config with atlas.server.ha.enabled=false (if 
> atlas.server.ha.enabled is set to true, still write it out as false)
> * multiple Atlas Servers => write config with atlas.server.ha.enabled=true 
> (only if atlas.server.ha.enabled is not a property, otherwise, take its value)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  c3af4eb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  36fb1ea 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  0b0d2ae 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  0fe0827 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  b595868 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 58cce06 
> 
> Diff: https://reviews.apache.org/r/49927/diff/
> 
> 
> Testing
> -------
> 
> Verified following use cases
> 
> 1 Atlas Server: set atlas.server.ha.enabled=false
> 1 Atlas Server with atlas.server.ha.enabled=true, changed 
> atlas.server.ha.enabled=false since doesn't make sense with a single server
> 2 Atlas Servers: set atlas.server.ha.enabled=true
> 2 Atlas Servers with atlas.server.ha.enabled=true, kept 
> atlas.server.ha.enabled=true
> 2 Atlas Servers with atlas.server.ha.enabled=false, kept 
> atlas.server.ha.enabled=false
> 
> mvn clean test
> ----------------------------------------------------------------------
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to